gh-96096: Add undocumented SQLITE_OK/DENY/IGNORE sqlite3 constants#96134
Merged
erlend-aasland merged 4 commits intoAug 23, 2022
Merged
Conversation
CAM-Gerlach
requested review from
berkerpeksag and
erlend-aasland
as code owners
CAM-Gerlach
added
needs backport to 3.10
erlend-aasland
changed the title
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Contributor
|
Let's land this; thanks for the PR, CAM, and thanks for the review Ezio! I'll try and come up with something that can make the whole authoriser section more accurate (and readable 😆). |
Contributor
|
Thanks @CAM-Gerlach for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 23, 2022
…nts (pythonGH-96134) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit d6259c5) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
|
GH-96202 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 23, 2022
…nts (pythonGH-96134) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit d6259c5) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
|
GH-96203 is a backport of this pull request to the 3.10 branch. |
| Flags that should be returned by the *authorizer_callback* callable | ||
| passed to :meth:`Connection.set_authorizer`, to indicate whether: | ||
|
|
||
| * Access is allowed (:const:`!SQLITE_OK`), |
Contributor
There was a problem hiding this comment.
Oh, I forgot the accidental comma! Note to self to fix it in an upcoming PR.
Member
Author
There was a problem hiding this comment.
Silly mistake; my fault again for being sloppy here
Contributor
There was a problem hiding this comment.
No problem, you're fine!
mdboom
pushed a commit
to mdboom/cpython
that referenced
this pull request
Aug 24, 2022
…nts (python#96134) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #96096 , add a formal description of the
SQLITE_OK/SQLITE_DENY/SQLITE_IGNOREconstants referenced inConnection.set_authorizer(), and update that method to elide duplicate content.Maybe some mention should be made of
SQLITE_OK's evident broader role? I'm not really well informed about the subject matter on this one to have any opinion on that.